EduarD3V/AutoFirme

Watch

Fork 0

E2E sign+verify: real valid FNMT cert (current-cert.p12) + generated self-signed p12 #54

Closed

EduarD3V wants to merge 0 commits from issue/39-e2e-sign-verify-real-valid-fnm into bullet-develop

EduarD3V commented

2026-10-15 06:35:11 +02:00

Owner

Implements #39.

Refs #39

Automated by bullet: reviewed (independent model) → gates green on merged tree. Auto-merge follows.

Implements **#39**. Refs #39 Automated by bullet: reviewed (independent model) → gates green on merged tree. Auto-merge follows.

EduarD3V added 13 commits

2026-10-15 06:35:13 +02:00

feat(pkcs12): read BER containers with indefinite lengths (Refs #39 ) d9eaa0e1ae

The real FNMT citizen keystore of #39 is written the way the Windows PKCS#12
exporter writes: no definite length above the leaves, chunked OCTET STRINGs,
and an implicit [0] encryptedContent built from chunks. Rejected as
"not a PKCS#12 container" before this.

- readTlv: indefinite lengths (X.690 8.1.3.6), flattening a constructed string
  into the primitive form every consumer expects.
- openSafeContents: ciphertext of a chunked implicit [0] is the concatenation
  of its chunks.
- verify/x509: DN table gains 2.5.4.42 (GN), so the verify report prints the
  same subject as the certificate picker.
- pkcs12.test.ts: DER -> BER re-encoder, round trip + openssl-checked signature.

test(e2e): sign+verify smoke for a real keystore and a generated one (Refs #39 ) 426dbab31b

scripts/smoke-real.sh drives the app's own modules end to end — load the
container, CAdES-sign a document, verify the .csig — and cross-checks the
result with openssl cms -verify and openssl x509 -subject -dates:

- --cert/--pin-file for the real keystore (gitignored, read at runtime, never
  printed); missing keystore or PIN file skips with a notice and exit 0.
- a generated self-signed container from src/test/fixtures.ts runs by default.
- asserts signature validity, signer identity (subject, issuer, serial,
  validity window) and the validity dates in the report output; the report's
  certChain status is printed as it is (signing embeds only the signer
  certificate, #6).
- pnpm verify:real runs it; README documents the headless run and the matching
  UI flow step by step.

test(fixtures): read xmlsec1 1.3.12's verification verdict (Refs #39 ) 6b32e900fc

The installed xmlsec1 1.3.12 prints `Verification status: OK` / `FAILED`, which the
oracle parser (built for a bare `OK`/1.3 `status: OK`) rejected as "no verdict" — five
XAdES/App tests failed on its output instead of on the signature. Accept the three
wordings; FAILED still maps to FAIL, so the tampered-document test keeps failing as
intended.

test(app): bound the jsdom crypto waits instead of testing-library's 1 s (Refs #39 ) 1e44aba046

Every run of App.test.ts failed 1-2 tests, a different set each time: the PKCS#12 load
and the signing round trip (PBKDF2 + AES + RSA import over Node's WebCrypto under
jsdom) sometimes take longer than the 1 s default waitFor, so the assertion ran before
the DOM update. Reproduced with this branch's src/lib changes reverted (1 failure), so
it predates #39. Same assertions, a realistic bound (the file already used 15 s for the
same kind of wait).

test: give the jsdom WebCrypto waits a shared ASYNC bound (Refs #39 ) 1bee11ac4e

One definition in src/test/fixtures.ts, used by the App, CertPicker and batch tests: the
asynchronous waits that follow a PKCS#12 load, a 250k-iteration seal, a signing round trip
or a store unlock were racing testing-library's 1 s default, so a full run failed a
different 1-2 tests every time. Assertions untouched.

docs(readme): name the real UI labels in the manual-evidence flow (Refs #39 ) 93bdb5d876

The app opens in Spanish, so the step list is only screenshot-able with the labels the
user actually sees; keep the English wording in brackets.

docs(readme): match the manual-evidence steps to the controls the app really shows (Refs #39 ) e2800d72e8

review: only universal strings chunk in indefinite BER (Refs #39 ) 797fbe6c82

review: wire --generated, clean the fixture dir, fix the UI docs (Refs #39 ) 76c57d796b

fix(review): pin the --generated flag wiring with a wrapper regression test (Refs #39 ) 4c7e7e9c76

fix(review): pin the generated-fixture temp-dir cleanup against leaks (Refs #39 ) 889aec9fa0

fix(review): run the README fixture command as an actionability test (Refs #39 ) 53c54ea9c2

review: run the smoke files serially so the leak count cannot race (Refs #39 ) e7610b7dcb

EduarD3V referenced this pull request

2026-10-15 06:35:15 +02:00

E2E sign+verify: real valid FNMT cert (current-cert.p12) + generated self-signed p12 #39

~~EduarD3V referenced this pull request 2026-10-15 06:36:11 +02:00~~

bullet: integrated work for human review #48

EduarD3V closed this pull request

2026-10-15 07:16:14 +02:00

EduarD3V referenced this pull request

2026-10-15 07:16:16 +02:00

E2E sign+verify: real valid FNMT cert (current-cert.p12) + generated self-signed p12 #39

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

EduarD3V/AutoFirme!54

No description provided.

Rows
Columns