Batch: agent work from agent-develop #101

Merged

EduarD3V merged 20 commits from agent-develop into develop 2026-10-09 18:30:25 +02:00

Conversation 0 Commits 20 Files changed 51 +1602 -128

gotoi-agent commented 2026-10-09 09:46:39 +02:00

Collaborator

Copy link

One batch of agent work, integrated on agent-develop and conflict-free against develop.

Commits:

5b84430 Merge pull request 'feat(plan): typed steps carry id, allow_failure, timeout_seconds' (#99) from issue/89-typed-steps into agent-develop
2cf65f0 Merge pull request 'Sync develop into agent-develop' (#100) from develop into agent-develop
aca2b39 feat(plan): typed steps carry id, allow_failure, timeout_seconds

Merged issue PRs:
Merge pull request 'feat(plan): typed steps carry id, allow_failure, timeout_seconds' (#99) from issue/89-typed-steps into agent-develop
Merge pull request 'Sync develop into agent-develop' (#100) from develop into agent-develop

CI runs on this PR: the five required contexts on develop must be green before it is merged.
Every contained PR was already green on its own branch.

Refs (#26 etc. - no closing keywords).

One batch of agent work, integrated on `agent-develop` and conflict-free against `develop`. Commits: ``` 5b84430 Merge pull request 'feat(plan): typed steps carry id, allow_failure, timeout_seconds' (#99) from issue/89-typed-steps into agent-develop 2cf65f0 Merge pull request 'Sync develop into agent-develop' (#100) from develop into agent-develop aca2b39 feat(plan): typed steps carry id, allow_failure, timeout_seconds ``` Merged issue PRs: Merge pull request 'feat(plan): typed steps carry id, allow_failure, timeout_seconds' (#99) from issue/89-typed-steps into agent-develop Merge pull request 'Sync develop into agent-develop' (#100) from develop into agent-develop CI runs on this PR: the five required contexts on `develop` must be green before it is merged. Every contained PR was already green on its own branch. Refs (#26 etc. - no closing keywords).

gotoi-agent added 3 commits 2026-10-09 09:46:40 +02:00

feat(plan): typed steps carry id, allow_failure, timeout_seconds ... aca2b39526

Plan.steps: string[] on wire stays byte-identical. Add optional typed overlay
via contract.typedSteps; bare string[] clients keep working unchanged.

- normalizeStepInput maps `string | {run, id?, allow_failure?, timeout_seconds?,
  description?}` onto a Plan.steps entry (run[]) and a contract.typedSteps
  entry (typed); both paths are read by the agent and the dashboard.
- Prose steps are rejected at create time with the 1-based offending index
  (skipped when steps contain an agent block). The length violation now names
  the index and the actual length; "step longer than 64 chars" is gone.
- allow_failure is enforced at middleware scoring time only; Go's Step has no
  such field and unknown YAML keys are ignored. timeout_seconds (1..86400)
  is emitted as the YAML `timeout:` for repo plans.
- New migration 0033_plan_typed_steps (typedSteps on plan_contract jsonb).
- UC-MW-174 typed steps surface; UC-MW-175 prose rejection at create time.
- 11 new tests (typed-step creation, normalizeStepInput, planFingerprint
  unchanged, the patched steps, the AllowFailure scoring seam, expiry-1..
  86400, dbColumn round-trip via the contract).

Gates:
- UC-MW-174 + UC-MW-175: 11 pass / 0 fail / 29 expect() / 16.15 s
- middleware/tests/uc-mw-cluster2-plans.test.ts: 17 pass / 1 fail
  (UC-MW-35 DELETE idempotent — pre-existing on base 038c94b, unrelated to
  this change)
- docs/use-cases/_check.py: 366 UCs conform
- scripts/check-ai-headers.py: 579 ok / 0 missing / 0 malformed
- scripts/check-type-mirror.py: clean (4 dashboard-only types noted as info)

Refs #89

Merge pull request 'Sync develop into agent-develop' (#100) from develop into agent-develop 2cf65f0e4f

Merge pull request 'feat(plan): typed steps carry id, allow_failure, timeout_seconds' (#99) from issue/89-typed-steps into agent-develop 5b84430f26

gotoi-agent added 6 commits 2026-10-09 13:02:22 +02:00

feat(plan): requirements reachable from create_plan/plan_update and the REST bodies ... 1f140de4bb

The control tool params omitted requirements, and planCreateBody/
applyPlanPatch dropped the field, so no path could declare what a plan
needs. Params, tool schemas, PLAN_PATCH_KEYS and the write path now carry
it through to compatibility scoring.

Refs #90 (UC-MW-176)

fix(plans): manual run refuses a host the plan's rules exclude ... 5a9cda9872

POST /plans/:id/run ignored rule hostnames/groupIds, so a plan pinned to
adam-slave-0 could be hand-run on any enrolled agent. The route now
considers every rule referencing the plan and refuses 409 unless at least
one allows the target host; no referencing rule stays unrestricted.

Refs #90 (UC-MW-177)

feat(executions): record what started a run as Execution.trigger ... 17d0e3934b

rule | manual | retry, stamped by the rule-matched pipeline and incident
paths, the manual run route, and retry; persisted in a nullable text
column (0034) and surfaced in execution summaries and the dashboard
mirror. Paths with no matched rule leave it undefined.

Refs #90 (UC-MW-177)

review(docs): drop doubled Related bullets in partner UCs ... c4de134b00

The related: edits for UC-MW-176/UC-MW-177 left '- - [link]' lines in
five partner UCs' Related headings. Single bullets again.

Refs #90

review(middleware): stamp trigger on agent-test, machine-command, rollback, chain runs ... 7d114889a1

Issue #90 requires every execution to record trigger. The control-chat
machine-command run and the operator agent test are manual dispatches;
rollback and chain continuations already carry the parent's ruleId, so
they inherit the parent trigger. Alert diagnostics with no matched rule
and agent-internal steps stay undefined (UC-MW-177 4a).

Refs #90

Merge pull request 'feat(plan): requirements reachable from create_plan and plan_update; dispatch honours rule hostnames' (#102) from issue/90-requirements-hostnames into agent-develop 3122e89e20

gotoi-agent added 3 commits 2026-10-09 16:08:18 +02:00

test: repro memory-ref staleness (red) Refs #91 c916504ded

feat(memory): typed refs go stale when the referenced object is deleted Refs #91 914bcffc30

Merge pull request 'Issue #91: memory rows naming gotoi object IDs go stale on delete' (#104) from issue/91-memory-row-invalidation into agent-develop ffa37d5df9

gotoi-agent added 3 commits 2026-10-09 16:39:17 +02:00

fix(dashboard): feed table always table-auto so nowrap cells never overlap (UC-FE-75) ... da354f8365

FeedTable used table-fixed w-full whenever the caller passed no columnStyle
(/plans/incidents, /plans/executions). table-cell carries whitespace-nowrap, so
each column locked to an equal fraction of the pane while its content was wider;
the text overflowed the cell box and painted over its neighbour, and the
overflow-auto wrapper had nothing to scroll because the table never exceeded
100%.

Measurements on the live stack at 700px: verdict cell clientWidth 87 vs
scrollWidth 119 (+32), status +19, planId +11; incidents at 390px warning +27,
resolved +30. /alerts already passed columnStyle and stayed on the table-auto
branch, and did not overlap.

Drop the table-fixed branch: the base table is always w-max min-w-full
table-auto, so columns size to content and the existing wrapper scrolls.
After: zero overflowing cells at 390/480/700px on both pages; wrapper scrollWidth
807 vs clientWidth 364 at 390px.

Also removes an incidental table-fixed source assertion from the UC-FE-27 test
(it pinned the defect), and records the narrow-width scroll rule in UC-FE-75.

Refs #93

review: correct UC-FE-75 flow line to the real width model (Refs #93) ... 44642b4f86

The story claimed a per-cell min-width; FeedTable applies no min-width on
the incidents/executions path (columnStyle is alerts-only, head cells only).
State the actual invariant: w-max min-w-full table-auto, matching DataTable.

Merge pull request 'Issue #93: feed tables never overlap cell text at narrow widths (table-auto + scroll)' (#105) from issue/93-table-fitting into agent-develop d9d3f53cc6

EduarD3V added 5 commits 2026-10-09 16:46:14 +02:00

docs(canon): reviewer is static-only, no branch-recovery deliberation (Refs #86) 0d8da7ee9b

docs(canon): performance-pass canvas (skips, gates, guard-invariants, cron-row) 259cc6bd7e

docs: rebase docs/reviewer-static-checkers onto agent-develop (Refs #86) 3fed0a90ab

Merge branch 'agent-develop' into docs/reviewer-static-checkers 7e8d7bb30a

Merge pull request 'docs(canon): reviewer-static + perf-pass (canvas drift fixes)' (#98) from docs/reviewer-static-checkers into agent-develop ... cd202e999a

Reviewed-on: #98

EduarD3V merged commit 1410e73aa1 into develop 2026-10-09 18:30:25 +02:00

EduarD3V referenced this pull request from a commit 2026-10-09 18:30:29 +02:00

Merge pull request 'Batch: agent work from agent-develop' (#101) from agent-develop into develop

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

ai-assist

Eligible for the autonomous issue pipeline — the runner only works issues carrying this label

  

needs_attention

Waiting on an operator decision. The runner skips this issue while the label is present; the operator answers with a DECISION: comment and the runner then applies it and clears this label.

  

verified

Operator verified the fix in production — runner closes it and does not re-work it

No labels

ai-assist

needs_attention

verified

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

EduarD3V/gotoi!101

No description provided.