Issue #1: Refactor and rethink of the plan attributes #2

Merged

EduarD3V merged 1 commit from issue/1-plan-attributes into develop

2026-10-04 19:04:11 +02:00

EduarD3V commented

2026-10-03 01:22:39 +02:00

Owner

Drops redundant, non-operator-facing attributes from the plan detail page (/plans/[id]): the full Id (UUID, already the route param), Commit (opaque hash, always empty for steps plans), Kind (raw remediation|diagnostic enum that drives agent-role scoring, not an operator decision), and the audit-only ownerId badge (per ADR-005 the organization is the only owner key; ownerId is audit-only). Updates UC-FE-41 to match. Closes #1.

Presentation-only: middleware model, DB schema and API contract untouched — every field stays on Plan.

Gates (all exit 0): docs/use-cases/_check.py; scripts/check-ai-headers.py; scripts/check-type-mirror.py; dashboard bun run test (230 passed); dashboard bun run check (0 errors); dashboard bun run build.

Flagged for review: (1) Kind is functional in coordinator.ts — restore that row if the page should advertise remediation vs diagnostic; (2) ownerId badge still rendered on /plans, sources, installs (tests pin those strings) — out of scope; (3) UC-FE-41 drift: it listed a Share button that does not exist.

Drops redundant, non-operator-facing attributes from the plan detail page (`/plans/[id]`): the full `Id` (UUID, already the route param), `Commit` (opaque hash, always empty for steps plans), `Kind` (raw remediation|diagnostic enum that drives agent-role scoring, not an operator decision), and the audit-only `ownerId` badge (per ADR-005 the organization is the only owner key; ownerId is audit-only). Updates UC-FE-41 to match. Closes #1. Presentation-only: middleware model, DB schema and API contract untouched — every field stays on `Plan`. Gates (all exit 0): docs/use-cases/_check.py; scripts/check-ai-headers.py; scripts/check-type-mirror.py; dashboard bun run test (230 passed); dashboard bun run check (0 errors); dashboard bun run build. Flagged for review: (1) `Kind` is functional in coordinator.ts — restore that row if the page should advertise remediation vs diagnostic; (2) `ownerId` badge still rendered on /plans, sources, installs (tests pin those strings) — out of scope; (3) UC-FE-41 drift: it listed a Share button that does not exist.

EduarD3V added 1 commit

2026-10-03 01:22:40 +02:00

dashboard: drop redundant plan detail attributes 579562d5e4

Remove the full uuid (Id), opaque commit hash, raw kind enum, and the
audit-only ownerId badge from /plans/[id]. ownerId is audit-only
(access.ts, ADR-005) and the org is the tenant; the uuid is the route
param; commit/kind are machine data with no operator action.

Update UC-FE-41 story and facts-card field list.

EduarD3V referenced this pull request

2026-10-03 01:22:50 +02:00

Refactor and rethink of the plan attributes #1

EduarD3V force-pushed issue/1-plan-attributes from 579562d5e4 to da64615c24

2026-10-03 10:26:01 +02:00

Compare

EduarD3V force-pushed issue/1-plan-attributes from da64615c24 to f90c374333

CI and agent release / test-dashboard (pull_request) Successful in 2m16s

Details

CI and agent release / test-agent (pull_request) Successful in 1m24s

Details

CI and agent release / check-docs (pull_request) Successful in 19s

Details

CI and agent release / test-middleware (pull_request) Failing after 7m27s

Details

CI and agent release / build (pull_request) Has been skipped

Details

CI and agent release / release (pull_request) Has been skipped

Details

CI and agent release / publish-images (pull_request) Has been skipped

Details

2026-10-03 10:29:23 +02:00

Compare

EduarD3V commented

2026-10-03 10:31:22 +02:00

Author

Owner

Rebased onto develop (now 33143a0) and force-pushed with --force-with-lease: the branch was cut from the old develop (7259c35) and main/develop had since added the git-plans work (0032, run-branch selector, tab scroll).

Conflict resolution, both edits kept where they are independent:

kept develop's Run-branch selector block and setRunBranch, and develop's overflow-x-auto tab list;
applied this issue's removals: ownerId badge, Id, Commit, Kind;
UC-FE-41 merged (version 2026-10-03, issue's story, facts-card list without Id/Commit/Kind).

Verified on the rebased tip f90c374: svelte-check 0 errors, bun run test 238 passed, bun run build ok, docs/use-cases/_check.py ok.

Rebased onto `develop` (now `33143a0`) and force-pushed with `--force-with-lease`: the branch was cut from the old `develop` (`7259c35`) and `main`/`develop` had since added the git-plans work (0032, run-branch selector, tab scroll). Conflict resolution, both edits kept where they are independent: - kept `develop`'s Run-branch selector block and `setRunBranch`, and `develop`'s `overflow-x-auto` tab list; - applied this issue's removals: `ownerId` badge, `Id`, `Commit`, `Kind`; - `UC-FE-41` merged (version 2026-10-03, issue's story, facts-card list without Id/Commit/Kind). Verified on the rebased tip `f90c374`: `svelte-check` 0 errors, `bun run test` 238 passed, `bun run build` ok, `docs/use-cases/_check.py` ok.

EduarD3V merged commit 68bed80a1b into develop

2026-10-04 19:04:11 +02:00

EduarD3V referenced this pull request from a commit

2026-10-04 19:04:14 +02:00

Merge pull request #2