Batch: agent work from agent-develop #80

Merged

EduarD3V merged 41 commits from agent-develop into develop 2026-10-08 07:32:58 +02:00

Conversation 1 Commits 41 Files changed 50 +1087 -316

gotoi-agent commented 2026-10-08 06:32:52 +02:00

Collaborator

Copy link

One batch of agent work, integrated on agent-develop and conflict-free against develop.

Commits:

84ff46b Merge pull request 'Issue #66: Docs sync — verify every document against the code and fix the drift' (#69) from issue/66-docs-sync into agent-develop
4d09445 Merge pull request 'Sync develop into agent-develop' (#61) from develop into agent-develop
924b95e Merge branch 'agent-develop' into issue/66-docs-sync
62cb34f Merge pull request 'Issue #73: Dark/Light/System theme + selector for marketing/ and docs-site/' (#77) from issue/73-theme-selector into agent-develop
1033abd docs-site: three-state theme switch with system following
1fdc243 marketing: dark/light/system theme with a nav selector and pre-paint init
55872c1 review(agent-pipeline): phase3 no longer contradicts its own S10/S13 headings
aead4df review(agent-pipeline): PR63's head reported statuses; silent ticks are not not-green
2d1d8bb docs(skills): three forgejo.py copies, and what actually blocks auto-merge
bb39774 docs(scripts): the TUI registry is five services, not three
f354d11 docs(agent-pipeline): S10 is built, the guards use the PR base ref, run-capture is off
9dd9f93 docs(agent-pipeline): the integrator is wired; what blocks it is the CI trigger
cd9b1d6 docs(agents): the branch law names agent-develop as the PR target

Merged issue PRs:
Merge pull request 'Issue #66: Docs sync — verify every document against the code and fix the drift' (#69) from issue/66-docs-sync into agent-develop
Merge pull request 'Sync develop into agent-develop' (#61) from develop into agent-develop
Merge branch 'agent-develop' into issue/66-docs-sync
Merge pull request 'Issue #73: Dark/Light/System theme + selector for marketing/ and docs-site/' (#77) from issue/73-theme-selector into agent-develop

CI runs on this PR: the five required contexts on develop must be green before it is merged.
Every contained PR was already green on its own branch.

Refs (#26 etc. - no closing keywords).

One batch of agent work, integrated on `agent-develop` and conflict-free against `develop`. Commits: ``` 84ff46b Merge pull request 'Issue #66: Docs sync — verify every document against the code and fix the drift' (#69) from issue/66-docs-sync into agent-develop 4d09445 Merge pull request 'Sync develop into agent-develop' (#61) from develop into agent-develop 924b95e Merge branch 'agent-develop' into issue/66-docs-sync 62cb34f Merge pull request 'Issue #73: Dark/Light/System theme + selector for marketing/ and docs-site/' (#77) from issue/73-theme-selector into agent-develop 1033abd docs-site: three-state theme switch with system following 1fdc243 marketing: dark/light/system theme with a nav selector and pre-paint init 55872c1 review(agent-pipeline): phase3 no longer contradicts its own S10/S13 headings aead4df review(agent-pipeline): PR63's head reported statuses; silent ticks are not not-green 2d1d8bb docs(skills): three forgejo.py copies, and what actually blocks auto-merge bb39774 docs(scripts): the TUI registry is five services, not three f354d11 docs(agent-pipeline): S10 is built, the guards use the PR base ref, run-capture is off 9dd9f93 docs(agent-pipeline): the integrator is wired; what blocks it is the CI trigger cd9b1d6 docs(agents): the branch law names agent-develop as the PR target ``` Merged issue PRs: Merge pull request 'Issue #66: Docs sync — verify every document against the code and fix the drift' (#69) from issue/66-docs-sync into agent-develop Merge pull request 'Sync develop into agent-develop' (#61) from develop into agent-develop Merge branch 'agent-develop' into issue/66-docs-sync Merge pull request 'Issue #73: Dark/Light/System theme + selector for marketing/ and docs-site/' (#77) from issue/73-theme-selector into agent-develop CI runs on this PR: the five required contexts on `develop` must be green before it is merged. Every contained PR was already green on its own branch. Refs (#26 etc. - no closing keywords).

gotoi-agent added 13 commits 2026-10-08 06:33:14 +02:00

docs(agents): the branch law names agent-develop as the PR target ... cd9b1d62ff

AGENTS.md still said every change lands on develop and issue branches are cut
from it. Three live sources disagree: the runner cron's law 2 sends issue
branches from origin/agent-develop and targets agent-develop, origin/agent-develop
is an ancestor of HEAD while origin/develop is not, and the integrator cron (PR
#61) operates agent-develop -> develop as a promotion.

State the three-branch flow: agent-develop absorbs agent PRs, develop receives
one promotion PR per batch, main receives the release cut.

Refs #66

docs(agent-pipeline): the integrator is wired; what blocks it is the CI trigger ... 9dd9f93c6d

integration-branch.md said `integrate.py` does not exist and nothing merges into
agent-develop — stale since the tool and its cron landed. triage.md §3 and
agent-issue-pipeline.md §5 repeated the same claim in passing.

Read back what is actually true: integrate.py is wired as the gotoi-integrator
cron (every 30 min, no-agent) and does trial-merge + required-context scoring +
sync + one promotion PR, but neither workflow triggers a pull_request run on
agent-develop (build-agent.yml:15, agent-guards.yml:10), so the five required
contexts never report, every PR scores not-green, and every merge so far is the
operator's (PR#63/#64/#65, merged_by EduarD3V).

Refs #66

docs(agent-pipeline): S10 is built, the guards use the PR base ref, run-capture is off ... f354d118d5

Three claims that no longer match the code:
- phase3-design.md S10 'not built' — hidden-tests.sh (manifest/inject/run/proof)
  landed 2026-10-06 12:20 (commit 70d37dd), after this file (a385678, 10:17);
  hidden-tests.md describes the proof. Mark built, keep the container gap.
- anti-tampering.md cites --base origin/develop; agent-guards.yml:37,44 passes
  --base "origin/$BASE_REF" with BASE_REF: github.base_ref, so the guard runs on
  main PRs too.
- reviewer.md says the report file is archived hourly by gotoi-run-capture; that
  cron job is disabled (paused 2026-10-07T07:37), so the file stays in RUN_ROOT.

Refs #66

docs(scripts): the TUI registry is five services, not three ... bb39774042

scripts/tui.py SERVICES has middleware, postgres, dashboard, docs (:3000) and
marketing (:5174); scripts/dev.sh:27 SERVICE_IDS matches. The layout diagram
showed three services, the key row read 1..3, and the prose said 'only gotoi
services (middleware, postgres, dashboard)'.

Also fix the branch-switch sentence: _restart_repo_services restarts every
running service whose type is 'bun', which now includes docs and marketing.

Refs #66

docs(skills): three forgejo.py copies, and what actually blocks auto-merge ... 2d1d8bb48b

The skill said two API-helper copies; there are three, md5-identical
(679a921f6181cfe6333c2acacbc8c4f1) — repo, ~/.claude and the orchestrator's
~/.hermes skill. The closing paragraph said the integrator 'does not exist';
it is wired as the gotoi-integrator cron and the runner law already targets
agent-develop — it merges nothing because CI never reports on an agent-develop
PR.

Refs #66

review(agent-pipeline): PR63's head reported statuses; silent ticks are not not-green ... aead4dffcd

The evidence block claimed every merge into the repo happened on heads with an
empty status list and that every cron tick prints not-green. API check: PR#63's
head carries 21 statuses (CI runs on develop PRs), and only ticks that see an
open PR print not-green (21 of 50 recorded outputs; the rest are silent).

Refs #66

review(agent-pipeline): phase3 no longer contradicts its own S10/S13 headings ... 55872c191d

The heading said S10 built while 'What remains' still listed it as pending, and
S13 read 'built once the queue carried real work' next to an empty-queue verdict
in the present tense. Remaining item is now the S10 container path; S13's
requirement/evidence text is marked as the original verdict and the planner is
described as offline-only (queue-plan.md: nothing calls it yet, selftest 8/8).

Refs #66

marketing: dark/light/system theme with a nav selector and pre-paint init ... 1fdc243bd2

Three-state Light/Dark/System control in the nav pill (desktop) and the mobile
panel, backed by a segmented group of the installed Button. The choice persists
under gotoi-theme — the same key the dashboard uses — and app.html resolves it
before first paint, so there is no flash of the wrong theme. The dark token
ladder already shipped; only the switch and the init were missing.

Refs #73

docs-site: three-state theme switch with system following ... 1033abd2e7

fumadocs already wires next-themes (class attribute, system default, pre-paint
inline script), but baseOptions left themeSwitch at its two-state default. Set
mode to light-dark-system so the docs sidebar and mobile header offer
Light/Dark/System, reuse the same component in the landing header so the site
root has a control too, and pin the switch's View Transitions cross-fade off
under prefers-reduced-motion.

Refs #73

Merge pull request 'Issue #73: Dark/Light/System theme + selector for marketing/ and docs-site/' (#77) from issue/73-theme-selector into agent-develop ... 62cb34f04a

Reviewed-on: #77

Merge branch 'agent-develop' into issue/66-docs-sync 924b95eac8

Merge pull request 'Sync develop into agent-develop' (#61) from develop into agent-develop 4d09445e00

Merge pull request 'Issue #66: Docs sync — verify every document against the code and fix the drift' (#69) from issue/66-docs-sync into agent-develop 84ff46b58c

gotoi-agent added 4 commits 2026-10-08 06:35:40 +02:00

fix(result): duplicate /result report is a true no-op ... 1f81996416

A retry that applyResult already resolved as already_done still fell through to
recordOutcome, the circuit breaker, rollback, recheck, and incident writes — so
duplicate POSTs inflated plan.verifiedStreak/totalVerified, double-counted
failures, and recordSuccess cleared a tripped circuit key (fail-open).

Return early on already_done, matching UC-OP-04 and UC-AG-10.

Refs #67

fix(tenancy): gate bulk group ops and plan child collections on row scope ... 30fa4e22d1

POST /agents/bulk group-add/group-remove checked only the agent rows, so any
operator could write another org's group hostnames. GET /plans/:id/executions,
/compatibility, and /health returned sibling-org rows for shared plans
(disk-cleanup). Both now resolve visibility against the active organization.

Refs #67

review(middleware): assert zero cross-org rows in shared-plan child collections ... 0372b9b8d8

The compatibility guard was 'counted <= 1', which still passes when a single
sibling-org agent leaks, and /plans/:id/health (also filtered by 30fa4e2) had
no assertion at all. Pin rows.length, compatibility count, and health.executions
to 0 for a reader outside the owning org.

Refs #67

Merge pull request 'Issue #67: Bug hunt — middleware and agent defects proven with red-first tests' (#74) from issue/67-bug-hunt into agent-develop d1884b4c49

gotoi-agent added 2 commits 2026-10-08 06:37:37 +02:00

middleware: gate GET /plans/ai/config to instance operators ... 37bb159341

The instance-operator rule for GET /plans/ai/config sat below the blanket
`if (m === 'GET' || m === 'HEAD') return 'viewer';`, so it was unreachable:
any authenticated org member could read the stored AI provider headers,
which may carry a private provider token.

Hoist the rule above the blanket GET rule and pin it with a red-first test.

Refs #68, UC-MW-167

Merge pull request 'Issue #68: Security review — middleware and agent (authn/authz, HMAC, secrets, SSRF)' (#75) from issue/68-security-review into agent-develop 98da205212

gotoi-agent added 7 commits 2026-10-08 06:39:17 +02:00

dashboard: move personalization page to /settings/personalization with an /operator shim ... 0ed997e7ac

The accent tint is a per-user preference; the operator layout gate no longer
applies to it. Refs #70

dashboard: point nav, destinations, page-help at /settings/personalization ... cd72fb1de9

Personalization becomes a Settings submenu item so every signed-in user
reaches it; the Operator group keeps only instance-operator surfaces. Refs #70

dashboard: pin the moved route in tests and the selenium walk ... e4b8c43189

UC-FE-80/-FE-83/-FE-85/-FE-99 lists now name /settings/personalization; the e2e
walk follows the old /operator URL as a redirect. Refs #70

docs: UC-FE-99/-FE-08/-FE-80 record the personalization move ... 0cce80a002

UC-FE-99 now describes a signed-in-user Settings page with a 308 shim on the
old route; UC-FE-08/-FE-80 drop it from the Operator module. Refs #70

review(dashboard): restore the profile-href assertions the move dropped ... 62469c4987

Refs #70

review(docs): UC-FE-08 flow step 4 lists Personalization in the Settings submenu ... a616a19a8d

Refs #70

Merge pull request 'Issue #70: Move personalization page to /settings/personalization (user-level)' (#76) from issue/70-personalization-move into agent-develop 60d98cff33

gotoi-agent added 11 commits 2026-10-08 06:40:31 +02:00

dashboard: move the row context menu and selection into the shared split-list compound ... c73183d9e0

SplitList.Items now owns the row context menu (target resolved from
data-item-id), the Select / Select all / Clear selection group, and the
selection bar; SplitList.Item renders the checkbox while selection mode is
on. app.css scopes a prefers-reduced-motion rule to the menu primitives.

Refs #72

dashboard: move the installs row menu onto the shared split-list primitive ... 40db0b38b0

The page keeps its decommission flow (two-step ConfirmDialog, typed
DECOMMISSION, api.agents.bulk) and supplies only menu/bulk snippets; the
former picking/pickedIds/ctxId state and data-agent-id plumbing are gone.

Refs #72

dashboard: shared row menu on plans, rules, and machines, single-item where no bulk route exists ... f2111dd4ab

/plans: open plan, change requests. /plans/rules: open, enable/disable,
delete (through the existing ConfirmDialog). /agents/machines: open
profile, control. Only /agents/bulk exists, so these pages carry no bulk
buttons rather than looping single-item requests behind the operator.

Refs #72

docs: UC-FE-100 for the shared SplitList row menu; refresh UC-FE-49 and UC-FE-95 ... 154486ec8d

Refs #72

review(dashboard): pass the machine hostname, not the row uuid, to Control from the row menu ... 50e98c0952

Refs #72

review(dashboard): add the detail pane's Add to group action to the machines row menu ... 89e785f6b5

Refs #72

review(dashboard): skip the shared row menu on lists that pass no ids or menu snippet ... 980610720b

Refs #72

review(docs): restore the UC-FE-95 live-poller extension and drop the duplicated 5a ... e669ff3514

Refs #72

review(dashboard): extract the split-list bulk bar into its own component per plan ... bfbaf0c5fe

Refs #72

review(dashboard): keep selection and the Select action off rows outside the passed ids ... bcdc5b23a9

Refs #72

Merge pull request 'Issue #72: shared SplitList row contextual menu + bulk actions (plans, rules, installs, machines)' (#78) from issue/72-datatable-row-menu into agent-develop 766f4f25ab

gotoi-agent added 4 commits 2026-10-08 06:44:53 +02:00

chore(integrator): gate agent-develop on trial merge only — CI contexts disabled there by operator (Refs docs) c839ca2012

fix(integrator): per-PR fault isolation, 300s merge timeout, null-safe read-back (Refs docs) d3f22ea127

Merge remote-tracking branch 'origin/agent-develop' into chore/integration-branch ... 504e06cdd5

# Conflicts:
#	scripts/agent-pipeline/integrate.py

Merge pull request 'Chore: integrator tolerates disabled CI contexts on agent-develop' (#79) from chore/integration-branch into agent-develop 99a5b20f2f

EduarD3V merged commit 9db4ace4f7 into develop 2026-10-08 07:32:58 +02:00

EduarD3V referenced this pull request from a commit 2026-10-08 07:33:03 +02:00

Merge pull request 'Batch: agent work from agent-develop' (#80) from agent-develop into develop

EduarD3V approved these changes 2026-10-08 07:33:03 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

EduarD3V

Labels

Clear labels   

ai-assist

Eligible for the autonomous issue pipeline — the runner only works issues carrying this label

  

needs_attention

Waiting on an operator decision. The runner skips this issue while the label is present; the operator answers with a DECISION: comment and the runner then applies it and clears this label.

  

verified

Operator verified the fix in production — runner closes it and does not re-work it

No labels

ai-assist

needs_attention

verified

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

EduarD3V/gotoi!80

No description provided.