Issue #85: typed object tools replace read_database_table (budget-gated writes) #94

Merged

gotoi-agent merged 12 commits from issue/85-typed-object-tools into agent-develop

2026-10-08 14:35:39 +02:00

gotoi-agent commented

2026-10-08 14:21:31 +02:00

Collaborator

No description provided.

gotoi-agent added 12 commits

2026-10-08 14:21:34 +02:00

middleware: typed control-chat object tools replace read_database_table 2afb694284

The single untyped read_database_table table browser is replaced by
per-object tools that project explicit fields, page with an opaque
cursor, and enumerate valid fields/statuses on a bad request:
plan_read, rule_read, incident_read, executions_for_plan, execution_read.
read_machine_context is renamed machine_read.

Writes gain plan_update, plan_delete, plan_test, rule_update and
rule_delete: all blocked in plan mode, operator-request gated, and
authorized per row via inScope. plan_test reports the dry run
(compatibility + kill switch + concrete commit) without calling
decide(), so it never enqueues and never leaks a lease.

middleware/src/ai-table-reader.ts is deleted; hub publishes remove
events for plan/rule deletes through the new optional hubRemove dep.

Refs #85

test: cover typed control-chat object tools and gate write tools by operator request 1542a81def

(Refs #85)

docs: UC-MW-136 covers typed control-chat object tools 3d3e31ab83

Rewrites the use case around per-object reads and writes, updates the
tool lists in UC-MW-151/UC-MW-169, the catalog index, and the two
plan documents that named read_database_table / read_machine_context.

Refs #85

test: pin plan_read summary totals and cursor to the store size 8907bb3544

(Refs #85)

test: use value-pinning matchers in the control object tool tests 934bc70589

(Refs #85)

review(middleware): restore ControlScope.denial member dropped by the typed-tools rewrite aa1bd25d09

The ControlScope interface hunk in 2afb694 replaced the denial member with
canWrite, but four call sites still use scope.denial (runOne, run_on_machines,
dispatch) and resolveControlScope still returns it — tsc reported TS2339/TS2353
on control-agent.ts. Refs #85

review(docs): align UC-MW-136 and the permissions-audit plan with the typed tool surface 6369ff0070

UC-MW-136 claimed every listed write runs blockInPlanMode +
requireOperatorRequest; plan_test runs neither (it is filtered from the
plan-mode tool list and has no operator-request gate), so the story and main
flow now separate it from the mutating writes. The permissions-audit plan
still told the reader to edit ai-table-reader.ts / readDatabaseTable, both
deleted by this issue — Task 3a and its test step now describe ControlRowVisibility
and the plan_read visibility check. Refs #85

middleware: compact object-tool descriptions to fit the 2048-token context window 086f5aa50c

Refs #85

Revert "middleware: compact object-tool descriptions to fit the 2048-token context window" 355a5f3b23

This reverts commit 086f5aa50c.

middleware: budget-gate the control write tools out of a tiny-window harness aabfcbdb98

Refs #85

review(middleware): prompt names the write tools the budget gate dropped 90625c2f3a

The budget gate advertised 14 of 21 tools on a tiny window while the
system prompt still told the model it operated through all of them, so
the first write attempt burned a turn on a harness tool error — in the
very window the gate exists to protect. The prompt now states which
tier was dropped; reads and the gate itself are unchanged.

Refs #85

review(test): pin the write-tier budget gate contract 24623ed0cb

fitControlTools had no direct assertions — only the end-to-end UC-MW-115
tiny-window chat. Two tests now pin the contract: a 2048-token window
drops exactly the seven write tools and keeps every read tool, and a
fitting or unknown window returns the tool list untouched.

Refs #85

gotoi-agent referenced this pull request

2026-10-08 14:22:53 +02:00

Replace read_database_table with typed object tools #85