EduarD3V/gotoi
Watch
1
0
Fork
You've already forked gotoi
 0
Code Issues 1 Pull requests Projects 1 Releases 5 Packages 5 Wiki Activity Actions

Issue #86: Plans report remediated after aborting (false green) #95

Merged
gotoi-agent merged 10 commits from issue/86-abort-false-green into agent-develop 2026-10-08 19:46:39 +02:00
Conversation 0 Commits 10 Files changed 29 +376 -96
gotoi-agent commented 2026-10-08 19:45:22 +02:00
Collaborator
Copy link

Fixes three defects from #86: outcome derives from step exit codes (any nonzero/timed-out step without allow_failure => failed), aborted is a first-class execution status set by the agent on workflow abort, and verify gains an exit-code mode (expect: {command, exit_code}). verificationOutcome can no longer be fix_claimed when a step failed.

UCs: UC-MW-170 (new), UC-AG-68 (new), UC-MW-16/107/122, UC-AG-12/64 updated.

Gates: UC catalog, ai-headers, type-mirror clean; middleware 605 pass / 1 pre-existing UC-MW-19 fail; dashboard test/check/build green; agent go test: touched workflow pkg ok, pre-existing env failures only; gofmt clean.

Review: round-1 REVIEW: PARTIAL fixes applied (9aee73b, 64b673d); round-2 reviewer session was interrupted mid-fix, its partial edits preserved on branch killed-reviewer-86-capture.

Refs #86

Fixes three defects from #86: outcome derives from step exit codes (any nonzero/timed-out step without allow_failure => failed), aborted is a first-class execution status set by the agent on workflow abort, and verify gains an exit-code mode (expect: {command, exit_code}). verificationOutcome can no longer be fix_claimed when a step failed. UCs: UC-MW-170 (new), UC-AG-68 (new), UC-MW-16/107/122, UC-AG-12/64 updated. Gates: UC catalog, ai-headers, type-mirror clean; middleware 605 pass / 1 pre-existing UC-MW-19 fail; dashboard test/check/build green; agent go test: touched workflow pkg ok, pre-existing env failures only; gofmt clean. Review: round-1 REVIEW: PARTIAL fixes applied (9aee73b, 64b673d); round-2 reviewer session was interrupted mid-fix, its partial edits preserved on branch killed-reviewer-86-capture. Refs #86
Refs #86
Refs #86
- applyResult scores from the last step: a failing or aborted run can never be remediated
- ExecutionStatus gains aborted; result enum, terminal lists, overview, and control poll include it
- PlanVerify.expect accepts { command, exit_code }; object form without an integer exit_code is rejected at create/patch
- recheck only compares the string form against PromQL output

Refs #86
An on_failure/goto/next abort hop sets an abort flag, and the run reports
status aborted instead of remediated, so middleware never scores a stopped
plan as fixed. Refs #86
StatusPill, ExecutionPeek retry, app.css destructive badge, and the types
mirror learn aborted. Refs #86
New UCs; UC-MW-16 notes rewritten to the derived-status rule; UC-MW-122,
UC-MW-107, UC-AG-12, UC-AG-64 related/versions updated. Refs #86
Refs #86
# Conflicts:
#	middleware/src/control-agent.ts
gotoi-agent merged commit d6bb5c3909 into agent-develop 2026-10-08 19:46:39 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-assist
Eligible for the autonomous issue pipeline — the runner only works issues carrying this label

  
needs_attention
Waiting on an operator decision. The runner skips this issue while the label is present; the operator answers with a DECISION: comment and the runner then applies it and clears this label.

  
verified
Operator verified the fix in production — runner closes it and does not re-work it

No labels
ai-assist
needs_attention
verified
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
EduarD3V/gotoi!95
No description provided.