bullet: integrated work for human review #18

Merged

EduarD3V merged 9 commits from bullet-develop into main

2026-10-14 13:20:28 +02:00

EduarD3V commented

2026-10-14 12:52:35 +02:00

Owner

Rolling PR. All bullet work lands on bullet-develop via per-issue PRs (auto-merged after review + gates). Merge this single PR into main when satisfied.

Integrated issues:

PR #16 — Use case: verify signatures (upload -> validity report)

Automated by bullet: implemented → reviewed (independent model) → gates green → auto-merged into bullet-develop. Trunk is human territory; this PR is the one button the human presses.

**Rolling PR.** All bullet work lands on `bullet-develop` via per-issue PRs (auto-merged after review + gates). Merge this single PR into `main` when satisfied. Integrated issues: - PR #16 — Use case: verify signatures (upload -> validity report) Automated by bullet: implemented → reviewed (independent model) → gates green → auto-merged into bullet-develop. Trunk is human territory; this PR is the one button the human presses.

EduarD3V added 6 commits

2026-10-14 12:52:36 +02:00

web: DER writer, and raw issuer/serial on parsed certificates (Refs #6 ) 68a674d83d

web: hand-built CAdES-BES detached SHA-256 signatures verified by openssl (Refs #6 ) 388e484dcf

web: sign the picked document and download the .csig (Refs #6 ) fab0842e6e

web: stop labelling the implemented CAdES format as pending (Refs #6 ) 7e4b55ee9b

Merge remote-tracking branch 'origin/main' into bullet-develop 10e66a73cc

Merge branch 'issue/6-use-case-cades-sign-in-browser' into bullet-develop 5834bc48ed

Conflict resolution (Refs #6): keep the integration's `implemented` format flag
(cades and xades true, pades false) and its generic signDone copy; keep
SelectedFile.source from #6; one App.svelte sign() dispatching XAdES/CAdES; keep
both the XAdES and CAdES UI tests (shared download-capture helper) and both sets
of fixtures (xmlsec1Verify + createCadesFixtures).

EduarD3V referenced this pull request from a commit

2026-10-14 12:55:21 +02:00

Merge bullet-develop: use cases #6 #7 integrated (rolling PR #18)

EduarD3V added 1 commit

2026-10-14 12:59:10 +02:00

Merge remote-tracking branch 'origin/main' into bullet-develop c8ff24f17b

Refs #8

EduarD3V added 8 commits

2026-10-14 13:06:11 +02:00

verify: DER/X.509/CMS engine for CAdES verification (Refs #8 ) 52d7555217

Hand-rolled DER reader, certificate parsing, WebCrypto signature verification and
issuer-link chain building; CAdES checks: structure, messageDigest vs content,
signature over re-encoded signedAttrs, signer cert, validity, chain, signingTime.

verify: XML canonicalization and XAdES verification with bundled FNMT root (Refs #8 ) 0f1161da2d

C14N 1.0 inclusive + exclusive (no comments) with the enveloped-signature transform,
XMLDSig SignedInfo signature and per-Reference digest checks, xades:SigningTime, and the
FNMT AC RAIZ FNMT-RCM trust anchor refreshed by scripts/fetch-roots.sh (fingerprint asserted).

web: verify mode with a per-check green/red validity report (Refs #8 ) 6b1172cde5

Sign/Verify tablist, drop-a-signature step, per-check cards with the technical reason,
signer/validity/signing-time summary and an optional original document for detached CAdES.

test: valid/tampered CAdES+XAdES fixtures, openssl cross-check, verifier tests (Refs #8 ) c691f2d7ba

Throwaway test PKI (keys gitignored), generator and openssl/python cross-check script, C14N
oracle vectors from python ElementTree.canonicalize, and vitest coverage of every check path.

docs: verify flow, trust anchors and fixtures in web/README (Refs #8 ) 1cefd5a93f

test: fail the signature check when the signature bytes themselves are tampered with (Refs #8 ) b0b3896cf4

The fixtures only tampered with the content, so nothing exercised the
cryptographic check on its own failure path. Flip a byte inside the CMS
signature OCTET STRING and inside the XAdES SignatureValue instead.

review: red structure card instead of crash on malformed input, fix BIT STRING trimming, mark fixture CRLF deliberate (Refs #8 ) 38de4931cc

Merge branch 'issue/8-use-case-verify-signatures-upl' into bullet-develop 8bd95a3f5c

Conflict resolution (integration #6/#7 side vs verify-signature side):
- App.svelte: keep #8's sign/verify mode tabs, but restore the real sign
  panel from #6/#7 (CertPicker onpick -> cert/chain, implemented-format
  guard, SignButton onsign); both import sets kept.
- App.test.ts: union of imports (PKCS#12 fixtures + fixture readers);
  both describe blocks kept.
- i18n.ts: keep both type imports (Pkcs12ErrorCode, CheckId) and both copy
  blocks.
- vite.config.ts: one test setup (src/test-setup.ts); drop #8's duplicate
  test/setup.ts (identical WebCrypto shim).
- README.md: merged module table (signing modules + verify engine, trust
  anchor script and fixtures).

Refs #8

EduarD3V merged commit b6632af162 into main

2026-10-14 13:20:28 +02:00

EduarD3V referenced this pull request from a commit

2026-10-14 13:20:30 +02:00

Merge pull request 'bullet: integrated work for human review' (#18) from bullet-develop into main