Too many fields on the alert source #21
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Sample url= http://100.118.73.36:5173/alerts/sources?id=checkmk
Here,, the alert source has multiple fields for the url:
URL, Port, Base URL.
The two first are not in http://100.118.73.36:5173/alerts/sources/new , only base url.
also for sources that are Poll type and not webhook type, like checkmk, it is still showing this block that only has to be show on webhook type:
PARTIAL DONE by gotoi-agent — PR #24 (issue/21-alert-source-fields -> develop), 3 commits b09a968/0915c6a/3ad8f17. Edit pane: URL+Port hidden for pull-capable kinds; one-time token box + Rotate row hidden in pull mode. Guided setup: post-Save webhook block gated on webhook mode; pull-mode note instead. Gates green: uc _check, ai-headers, type-mirror, dashboard test 238 pass, svelte-check 0 errors, build ok, hidden set 1 pass. Not browser-verified (auth-gated pages, no session in worktree) — reviewer with a session should eyeball /alerts/sources?id=checkmk and /alerts/sources/new -> Checkmk -> Save. Refs #21
Claimed — branch
issue/21-alert-source-fields. Doing: hide the duplicate URL/Port fields on the source detail pane for pull-capable kinds and hide the post-Save webhook token/URL/headers block for pull-mode sources in guided setup.Plan: /home/eduardez/workspace/gotoi-wt/meta/issue-21.plan.md
Tasks:
!pullPreset; gate token box + Rotate row on!pullMode(dashboard/src/routes/alerts/sources/+page.svelte)created && !pullModein /alerts/sources/newDONE — refs #21 (issue stays open).
Commits:
b09a968(detail pane hides URL/Port + token box for pull kinds),0915c6a(guided setup hides post-Save webhook block in pull mode),3ad8f17(UC source assertions).Gates: UC _check 0 · check-ai-headers 0 · check-type-mirror 0 · dashboard bun run test 238 passed · bun run check 0 errors · bun run build 0.
Limit: no browser smoke (routes are auth-gated, no unattended session) — verified via svelte-check + build + page assertions. Report: /home/eduardez/workspace/gotoi-wt/meta/issue-21.report.md